Shutdown the server if any of the tasks crashes #3672
Merged
+57
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
657b3de
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://80b9feee.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-shutdown-on-crash.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/shutdown-on-crash
branch
from
990b992 to
414fe21
Compare
reivilibre
approved these changes
Dec 16, 2024
| if likely_crashed { | ||
| ExitCode::FAILURE | ||
| } else { | ||
| ExitCode::SUCCESS |
There was a problem hiding this comment.
I guess that's orthogonal to this PR, but is exiting with SUCCESS really the right thing to do if exiting due to a SIGTERM or so?
It's possible the SIGTERM was sent by another process due to an out of memory situation or something like that, but then a successful exit code doesn't necessarily trigger a restart in e.g. systemd by default. (I've had this failure mode with other services in the past.)
I mostly just wonder what the convention is for this.
There was a problem hiding this comment.
Hmmm SIGTERM is usually sent when asking for a graceful shutdown. Docker/Kubernetes does that, systemd probably as well
sandhose
force-pushed
the
quenting/shutdown-on-crash
branch
from
0bbc59a to
c66f37f
Compare
sandhose
force-pushed
the
quenting/shutdown-on-crash
branch
from
c66f37f to
657b3de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid to be in a state where the activity tracker, the task worker or the listener crashed, but the app is still running.
This works by having each task have a drop guard on a cancellation token, meaning that if the task is being dropped, the cancellation token is cancelled, which will cause other tasks to stop as well.
If the service is stopeed that way, it will also use a failure exit code to indicate that the service has been stopped unexpectedly.
Fixes #2625