Make the release process create annotated tags #3686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
90e93a8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://203ccd42.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-release-annotated-t.matrix-authentication-service-docs.pages.dev |
reivilibre
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I implemented version reporting using
git describe(#3671), I was confused why the release tags were 'lightweight' tags, not annotated ones.Looks like we were correctly creating the tag object, but then pushing the commit object as
refs/tags/vX.Y.Z, instead of the tag object.This fixes that, so after the next release we'll be able to make the
git describeonly look for annotated tags here