Allow response_mode to be null and if so do not add the query param #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMaul
force-pushed
the
response-mode-default
branch
from
fdd796d to
8c59ebe
Compare
sandhose
requested changes
Dec 17, 2024
| @@ -235,13 +235,17 @@ pub async fn config_sync( | |||
| } | |||
| }; | |||
|
|
|||
| let response_mode = match provider.response_mode { | |||
There was a problem hiding this comment.
Using provider.response_mode.map(…) would help simplify this
| mode => Ok(mode), | ||
| } | ||
| } else { | ||
| Ok(M::Fragment) |
There was a problem hiding this comment.
It's unclear to me why this has to change? This code is for the client -> MAS login part, and it is spec-compliant, nothing to do with the upstream provider stuff
Comment on lines
+227
to
+228
| method => { | ||
| return Err(RouteError::InvalidReqMethod { method }); |
There was a problem hiding this comment.
This should never happen, the route is installed as POST and GET handler anyway
| let html = templates.render_form_post(&context)?; | ||
| return Ok(Html(html).into_response()); | ||
| } | ||
| match method { |
There was a problem hiding this comment.
I'm finding the old single match on the tuple easier to read. Could you go back to using that?
| @@ -0,0 +1 @@ | |||
| ALTER TABLE "upstream_oauth_providers" ALTER COLUMN "response_mode" DROP NOT NULL; | |||
There was a problem hiding this comment.
Can you add the copyright header + a short description of what this migration does?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.