Allow passing impersonated device ID to Intent #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating an impersonating client for an appservice, allow passing in a device ID to use. This will make the requests have `org.matrix.msc3202.device_id` in the query string for the client requests.
Half-Shot
approved these changes
Jul 24, 2024
src/appservice/Intent.ts
Outdated
| /** | ||
| * Gets the device ID this intent is for. | ||
| */ | ||
| public get deviceId(): string { |
When creating an impersonating client for an appservice, allow passing in a device ID to use. This will make the requests have `org.matrix.msc3202.device_id` in the query string for the client requests. Appservice `intentsConfig` can be provided with a `botDeviceId`, which will be passed into creating the `Intent` for the bot user only.
jaywink
force-pushed
the
jaywink/impersonating-intent-devices
branch
from
3230ab4
to
2a4f9ce
Compare
Half-Shot
approved these changes
Jul 26, 2024
| /** | ||
| * Get the application service's "bot" user device ID. | ||
| */ | ||
| public get botDeviceId(): string { |
There was a problem hiding this comment.
Suggested change
| public get botDeviceId(): string { | |
| public get botDeviceId(): string|undefined { |
This still doesn't return just a string :)
|
This was not required after all, so closing to avoid adding unnecessary code with no proven use cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an impersonating client for an appservice, allow passing in a device ID to use. This will make the requests have
org.matrix.msc3202.device_idin the query string for the client requests.Signed-off-by: Jason Robinson jasonr@element.io
Checklist