This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Upgrade emojibase-bindings and remove local handling of emoticon variations #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langleyd
changed the title
…ment-hq/matrix-react-sdk into langleyd/emoitcon_variations
t3chguy
reviewed
Oct 8, 2024
| @@ -427,7 +427,7 @@ describe("WysiwygComposer", () => { | |||
| }); | |||
| it("typing a space to trigger an emoji replacement", async () => { | |||
| fireEvent.input(screen.getByRole("textbox"), { | |||
| data: ":P", | |||
| data: ":-P", | |||
There was a problem hiding this comment.
This implies that :P no longer works?
There was a problem hiding this comment.
I was testing this locally, I didn't mean to push up this change. Will add as a second case. Thanks for pointing it out.
t3chguy
approved these changes
Oct 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#27989
Depends on matrix-org/emojibase-bindings#21
The emojibase repo now has a function for handling emoticon variations. This means we don't have to handle it locally, it work for RTE and the CIDER editor and also adds some additional variations.
Screen.Recording.2024-10-07.at.16.25.10.mov