Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Update codeowners to element-hq teams #3

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Update codeowners to element-hq teams #3

merged 3 commits into from
Sep 9, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Sep 6, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

/test/components/views/dialogs/security/ @matrix-org/element-crypto-web-reviewers
/src/stores/SetupEncryptionStore.ts @matrix-org/element-crypto-web-reviewers
/test/stores/SetupEncryptionStore-test.ts @matrix-org/element-crypto-web-reviewers
/src/SecurityManager.ts @element-hq/element-crypto-web-reviewers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this team doesn't exist on element-hq.

Should that be created or use element-crypto for now @richvdh

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it can't be a secret team - I've changed it to public but it might take a while for GH to realise and update the codeowners file check.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, obviously it was because I forgot to add the team's access to the repo 🤦

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dbkr dbkr merged commit d4771dd into develop Sep 9, 2024
24 of 26 checks passed
@dbkr dbkr deleted the dbkr/codeowners branch September 9, 2024 08:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants