Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Mobile registration optimizations and tests #62

Merged
merged 7 commits into from
Sep 20, 2024
Merged

Mobile registration optimizations and tests #62

merged 7 commits into from
Sep 20, 2024

Conversation

langleyd
Copy link
Member

@langleyd langleyd commented Sep 19, 2024 •
edited
Loading

What's in this PR?

  • don't autocaptialize or autocorrect on username field
  • show each password field in their own row vs in the same row
  • improve position of tooltip on mobile so that it's visible
  • Redirect to welcome screen if mobile_registration is requested but not enabled in the config.
  • Tests that were missing from the initial PR for mobile registration.

@langleyd
Mobile registration optimizations
44c0db2 
- don't autocaptialize or autocorrect on username field
- show each password field in their own row
- improve position of tooltip on mobile so that it's visible
@langleyd langleyd marked this pull request as ready for review September 20, 2024 10:56
@langleyd langleyd requested a review from a team as a code owner September 20, 2024 10:56
@langleyd langleyd changed the title Mobile registration optimizations Mobile registration optimizations and tests Sep 20, 2024
@langleyd langleyd added this pull request to the merge queue Sep 20, 2024
@langleyd langleyd removed this pull request from the merge queue due to a manual request Sep 20, 2024
@langleyd langleyd enabled auto-merge September 20, 2024 11:08
@langleyd langleyd added this pull request to the merge queue Sep 20, 2024
Merged via the queue into develop with commit 1f55710 Sep 20, 2024
27 checks passed
@langleyd langleyd deleted the langleyd/mobile_registration_optimisations branch September 20, 2024 11:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langleyd @dbkr