This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs element-hq/compound-web#248 for fixing the type error. |
MidhunSureshR
force-pushed
the
midhun/compound-upgrade
branch
from
September 24, 2024 09:05
48ed462
to
d3d6f2c
Compare
MidhunSureshR
force-pushed
the
midhun/compound-upgrade
branch
from
September 24, 2024 18:16
4978422
to
95b6b1b
Compare
MidhunSureshR
force-pushed
the
midhun/compound-upgrade
branch
from
September 28, 2024 20:07
6e3ef61
to
481ea9e
Compare
Maybe this could be broken down to 2, decoupling the |
richvdh
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the crypto POV. Will leave it to the web team to decide if they are happy with combining the jest-matrix-react
stuff with the compound upgrade
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compound-web 6.0.0 release introduced some breaking changes related to Tooltips.
<TooltipProvider>
component to all the root components. It was removed in Use new compound tooltip matrix-org/matrix-react-sdk#12416.<TooltipProvider>
. All tests must now import fromjest-matrix-react
instead of@testing-library/react
. An eslint rule is added to enforce the same.label
to Tooltip, it acts as an accessible label for the enclosed element. Also when used in this manner,role=tooltip
is not added. Since this was the primary way tooltips were found and asserted, a lot of tests broke. They are fixed by searching via text or by usingdescription
prop instead of `label prop.wrap-ansi
andwrap-ansi-cjs
to a specific version. Yarn is otherwise unable to understand that these are both the same package. This would result inyarn install
failing perpetually.<ToggleMenuItem>
no longer has anonChange
, updated src/components/views/right_panel/RoomSummaryCard.tsx.floating-ui-
. These are the divs outside.MatrixChat
where the tooltips are rendered. The reason for fail:Ensure all page content is contained by landmarks
. Since the tooltips are only shown on user interaction, this is probably fine.