Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Open room settings on room header avatar click #88

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Sep 24, 2024

Fixes element-hq/element-web#28030

Screenshot changes as for whatever reason Chrome renders text in buttons vs spans slightly differently, no amount of CSS trickery seems to avoid it.

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've also lost a tooltip: is that intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the showTooltips option was broken, in order to stabilise one of the tests here I fixed the option which made one of the other screenshots lose its tooltip

@t3chguy t3chguy added this pull request to the merge queue Sep 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 26, 2024
@t3chguy t3chguy added this pull request to the merge queue Sep 26, 2024
Merged via the queue into develop with commit 34d1875 Sep 26, 2024
27 checks passed
@t3chguy t3chguy deleted the t3chguy/fix/28030 branch September 26, 2024 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the avatar in the room header open Room Settings on click.
2 participants