Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require the 'from' parameter for /notifications be an integer #17283

Merged
merged 7 commits into from
Jun 19, 2024

Commits on Jun 7, 2024

  1. Require the 'from' parameter for /notifications be an integer.

    While this is classed as a 'string' in the spec,
    the provided value must be an integer in order
    for pagination to work. Thus any non-integer value
    must be rejected.
    anoadragon453 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    1244223 View commit details
    Browse the repository at this point in the history
  2. Add a general and regression test

    Adds a test for pagination for /notifications. We also add a regression
    test for the 'from' parameter not being an integer.
    
    I wanted to break this up into two commits, but PyCharm made it hard.
    anoadragon453 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    4e31809 View commit details
    Browse the repository at this point in the history
  3. changelog

    anoadragon453 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    8b2592c View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Remove empty query parameter from test

    I'm not sure why it was there.
    anoadragon453 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    df4dd8a View commit details
    Browse the repository at this point in the history
  2. Provide a less obtuse error message

    Instead of telling the client that they should have used an integer -
    which could be confusing as the spec says that the query parameter must
    be a string - we simply tell the client that their "from" token is
    unknown to us.
    anoadragon453 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    59693b7 View commit details
    Browse the repository at this point in the history
  3. lint

    anoadragon453 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    5f1b358 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Update changelog.d/17283.bugfix

    Co-authored-by: Erik Johnston <erikj@element.io>
    anoadragon453 and erikjohnston committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    12fb7d0 View commit details
    Browse the repository at this point in the history