Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up integer parsing #17339

Merged
merged 6 commits into from
Jun 24, 2024
Merged

Tidy up integer parsing #17339

merged 6 commits into from
Jun 24, 2024

Commits on Jun 20, 2024

  1. Fix documentation for parse_integer regarding negatives. 

    The parse_integer was previously made to reject negative values by
default, but the documentation stated otherwise. This fixes the
documentation and also:

- Removes explicit negative=False parameters from call sites.
- Brings the negative default of parse_integer_from_args in alignment
  with parse_integer.
    @dkasak
    dkasak committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    d43f6df View commit details
    Browse the repository at this point in the history

  2. Clarify parse_integer* docs.

    @dkasak
    dkasak committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    fd8c9aa View commit details
    Browse the repository at this point in the history

  3. Remove dead validation code from client /hierarchy handler.

    @dkasak
    dkasak committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    a5f61b0 View commit details
    Browse the repository at this point in the history

  4. Add newsfile.

    @dkasak
    dkasak committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    47a5799 View commit details
    Browse the repository at this point in the history

  5. Remove one more instance of dead validation code.

    @dkasak
    dkasak committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    0c67c41 View commit details
    Browse the repository at this point in the history

  6. Fix newsfile.

    @dkasak
    dkasak committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    1b599cc View commit details
    Browse the repository at this point in the history