Implement MSC4133 to support custom profile fields. #17488
Conversation
synapse/handlers/profile.py
Outdated
| "displayname": profileinfo.display_name, | ||
| "avatar_url": profileinfo.avatar_url, | ||
| } | ||
| # TODO Should this strip out empty values? |
There was a problem hiding this comment.
I would think not - that could result in users having fields stay around forever in the DB, yet never visible to users.
| @@ -813,7 +813,7 @@ def is_allowed_mime_type(content_type: str) -> bool: | |||
|
|
|||
| # bail if user already has the same avatar | |||
| profile = await self._profile_handler.get_profile(user_id) | |||
| if profile["avatar_url"] is not None: | |||
| if "avatar_url" in profile: | |||
There was a problem hiding this comment.
Do we still need to check whether profile["avatar_url"] is None before attempting to .split on it?
There was a problem hiding this comment.
I suspect I need to split this to a separate PR to make it clear what the change is.
synapse/storage/schema/main/delta/86/01_custom_profile_fields.sql
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
|
I pushed some changes to update / flesh out the rest of the MSC, but I haven't yet gone through @anoadragon453's comments so not worth another review yet. (If folks want to test it that would be reasonable...I'm sure it'll break.) |
clokep
changed the title
|
|
|
I think this is close to ready for another review. There's a few open questions on the MSC that will affect this still. |
This is essentially matrix-org/synapse#14392. I didn't see anything in there about updating sytest or complement. The main driver of this is so that I can use `jsonb_path_exists` in #17488. 😄
Implementation of MSC4133 to support custom profile fields. It is behind an experimental flag and includes tests.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)