Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to load local data #403

Merged
merged 4 commits into from
Jul 20, 2017
Merged

Add option to load local data #403

merged 4 commits into from
Jul 20, 2017

Conversation

donadigo
Copy link
Contributor

@donadigo donadigo commented Jul 17, 2017

This branch adds a new command line --load-local option to load AppStream XML data files. This branch also changes that all options are now displayed when you execute appcenter --help.

The data is parsed into a package and the package is then added to the banner if parsing was successfull. Packages that are loaded locally have a (local) suffix in their name to distinguish them from the actual package with the same name. Local packages are also searchable and appear under native category although they cannot be installed / uninstalled nor updated.

Usage:
appcenter --load-local /path/to/xml/file

It might be worth to add this feature to docs so that devs can test their appdata if this gets merged into master.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor niggle, but otherwise it seems to work as expected and I think this will be great for developers :)

return null;
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra newline here?

@danirabbit danirabbit merged commit cf31a22 into master Jul 20, 2017
@danirabbit danirabbit deleted the load-local-appstream-data branch July 20, 2017 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants