Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppDirs: Fix loading plugins #770

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Conversation

ryonakano
Copy link
Contributor

@ryonakano ryonakano commented Jun 30, 2024

Resources.LIB already has the /usr (or /app if Flatpak) prefix in meson.build so the previous code tries to search for /usr/usr/lib/x86_64-linux-gnu or /app/app/lib and causes the critical messages displayed on the terminal when launching and plugins not shown in the preferences dialog.

Before

user@VirtualBox-17958d80:~/work/photos$ LANG=C io.elementary.photos 
** Message: 01:20:46.822: main.vala:347: Photos Photo Manager 8.0.0

(io.elementary.photos:67956): GLib-GIO-CRITICAL **: 01:20:46.835: g_file_get_child: assertion '!g_path_is_absolute (name)' failed

(io.elementary.photos:67956): GLib-GIO-CRITICAL **: 01:20:46.835: g_file_get_child: assertion 'G_IS_FILE (file)' failed

(io.elementary.photos:67956): GLib-GIO-CRITICAL **: 01:20:46.835: g_file_get_child: assertion 'G_IS_FILE (file)' failed

** (io.elementary.photos:67956): CRITICAL **: 01:20:46.836: plugins_search_for_plugins: assertion 'dir != NULL' failed
** Message: 01:20:46.836: main.vala:57: Verifying database ?
** Message: 01:20:46.841: VideoSupport.vala:403: interpreter state cookie not found; assuming all video thumbnails are out of date

(io.elementary.photos:67956): GLib-GObject-CRITICAL **: 01:20:46.884: value "-1" of type 'gint' is invalid or out of range for property 'position' of type 'gint'

Screenshot from 2024-06-30 10-29-04

After

user@VirtualBox-17958d80:~/work/photos$ LANG=C io.elementary.photos 
** Message: 01:21:07.239: main.vala:347: Photos Photo Manager 8.0.0
** Message: 01:21:07.254: main.vala:57: Verifying database ?
** Message: 01:21:07.260: VideoSupport.vala:403: interpreter state cookie not found; assuming all video thumbnails are out of date

(io.elementary.photos:68045): GLib-GObject-CRITICAL **: 01:21:07.289: value "-1" of type 'gint' is invalid or out of range for property 'position' of type 'gint'

Screenshot from 2024-06-30 10-27-49

Resources.LIB already has the /usr (or /app if Flatpak) prefix in meson.build
so the previous code tries to search for /usr/usr/lib or /app/app/lib
@ryonakano ryonakano changed the title AppDirs: Fix get_lib_dir AppDirs: Fix loading plugins Jun 30, 2024
@danirabbit danirabbit merged commit cc5af83 into master Jun 30, 2024
3 checks passed
@danirabbit danirabbit deleted the ryonakano/fix-get-lib-dir branch June 30, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants