Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocaleView: absorb progressdialog #197

Merged
merged 5 commits into from
Mar 10, 2024
Merged

LocaleView: absorb progressdialog #197

merged 5 commits into from
Mar 10, 2024

Conversation

danirabbit
Copy link
Member

  • Removes some public API
  • Fix implicit begin while we're here

@danirabbit danirabbit requested a review from a team March 8, 2024 19:11
@jeremypw
Copy link
Collaborator

jeremypw commented Mar 9, 2024

@danirabbit Please fix conflicts, thanks.

@danirabbit
Copy link
Member Author

@jeremypw done!

jeremypw
jeremypw approved these changes Mar 10, 2024
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, no regressions found.

@jeremypw jeremypw enabled auto-merge (squash) March 10, 2024 16:24
@jeremypw jeremypw merged commit 7c16ba8 into main Mar 10, 2024
2 of 4 checks passed
@jeremypw jeremypw deleted the danirabbit/localeview-progressdialog branch March 10, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw