-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GnomeRemoteDesktopSupport WIP #60
base: main
Are you sure you want to change the base?
Conversation
export DISPLAY=:0.0 | ||
killall io.elementary.switchboard -9 | ||
sudo rm -fr build/ | ||
sudo meson build --prefix=/usr | ||
cd build/ | ||
sudo ninja | ||
sudo ninja install | ||
cd ../ | ||
io.elementary.switchboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this should be part of the repo. If you need it in your source tree you should not add it to commits and set .gitignore
to exclude it.
Personally I set up an alias in ~/.bashrc
to do something similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this should be part of the repo. If you need it in your source tree you should not add it to commits and set
.gitignore
to exclude it.Personally I set up an alias in
~/.bashrc
to do something similar.
Will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this should be part of the repo. If you need it in your source tree you should not add it to commits and set
.gitignore
to exclude it.Personally I set up an alias in
~/.bashrc
to do something similar.
Thanks for reminding me about that, that would save some time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to revert this commit?
There are a number of elementaryos code style issues. You should install |
Thanks for making a start on this though! I'll try to look at it in more detail soon. |
I have inserted "Fixes #56" into the description so that if this PR is merged into master then that issue is automatically closed (I assume that this PR is intended to completely resolve that issue). I am not sure if this PR is complete and working? If it is not then please convert to "draft" - it will still be visible and attract comment. |
How |
by adding SettingsBindFlags.INVERT_BOOLEAN Remote Control switch work like the one in Gnome Control Panel -> Sharing -> Remote Desktop where ON = OFF & OFF = ON Setting Key is called view-only & Remote Control sound batter.
@BAProductions For my own PRs I see an option to convert to draft just under the "Reviewers" section on the right hand side: Oh - I see you have done it! |
This commit fix a bug that was created when I add Gnome Remote Desktop Support panel to this repo witch does not hide the vnc_url & it label when the switch is turn off.
Note: Spelling of "Legicy" should be "Legacy". |
Note: Spelling of "Legicy" should be "Legacy".
Fixes #56
Problem
Since installing eOS 6-6.1 on my HTPC and early this years upgrading my HTPC with newer Parts and installing eOS 7-7.1 on my old HTPC in a VM that's ruining on a 500GB SATA SSD via Project-Cockpit Running on Ubuntu Server 24.04 on a 2 Core intel i3 i decided to revisit the hole vnc thing and after doing some research I came Gnome vino-server Gnome Remote Desktop & Gnome Remote Connection witch lead me issue #56 here a user made a post about adding Gnome Remote Desktop to eOS an after installing Gnome Control Center on eOS 7-7.1 & madding with gsetting and dconf editor it works beautifully with barely any lags at all
Proposal
My proposal Is to add Gnome Remote Desktop and Gnome Remote Connection support to elementary/switchboard-plug-sharing and all feedback is appreciated.
Prior Art (Optional)