Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor luma account tests #111

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gregor-RW
Copy link
Contributor

Cleanup of Account Spec tests for Luma theme. Things done:

  1. Break down the Account Activities and create Account login/logout and Account Address Activities to better separate the test logic (and optimize the usage of before/beforeEach/after in each of them)
  2. Introduction of Magento2RestApi.replacePassword() to not rely on the frontend to change the password back
  3. Introduction of Account.deleteAddress() to handle Addresses cleanup after Account Address Activities tests
  4. Left some TODOs that can be extracted as separate issues and can be a good FirstIssue type for the project

@gregor-RW
Copy link
Contributor Author

gregor-RW commented Jul 16, 2023

None of the GitHub Actions CI tests relate to Luma. Can someone manually confirm that its working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant