Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add all required packages to readme #44

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

kolaente
Copy link
Collaborator

I set up the project, opened cypress and it told me I need cypress-tags and typescript - installed these in the project but figured others might run into this too.

@peterjaap
Copy link
Contributor

I'll add it in but it was already in the readme; https://github.com/elgentos/magento2-cypress-testing-suite#tags

@peterjaap peterjaap merged commit 6ebc1b9 into elgentos:main Mar 22, 2022
@kolaente kolaente deleted the fix/initial-packages-readme branch March 22, 2022 11:52
@kolaente
Copy link
Collaborator Author

Ah okay, didn't see that. Maybe it would make sense to no include the tags plugin by default in that case? Right now it gets included when copying over all cypress testing files from the repo and won't work out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants