fix: don't stop running all other tests when one failed if running headless #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed! Thanks. |
|
Still I find the solution a bit implicit, it's a heuristic which does not always fit reality :-) Maybe we should introduce such a variable DONT_STOP_ON_FAILS ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed no tests were running in our CI environment where automatic retries take care of the performance difference of the CI environment. Only failing the tests when not running headless keeps the development benefit but usually when running headless you want an overview of all failing tests.
This could probably be changed with an
CYPRESS_RUNNING_IN_CIenv variable or something like that but checking for headless works well enough in our use case and doesn't require a new variable.