Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Hyva 1.1.16 #60

Merged
merged 7 commits into from
Jul 28, 2022
Merged

Conversation

Vinai
Copy link
Collaborator

@Vinai Vinai commented Jul 27, 2022

This MR includes the changes from #57 (fix fixture imports) and #58 (migrate to Cypress v10.x).

Closes #59

Vinai and others added 7 commits July 26, 2022 10:45
Since the configuration now is JS and not JSON, more support for
configuration through env variables was added.

* CYPRESS_MAGENTO2_BASE_URL
* CYPRESS_MAGENTO2_SPEC_PATTERN
* CYPRESS_MAGENTO2_DEFAULT_TIMEOUT

Closes elgentos#52
This PR does not include fixes for the checkout tests - if any are
actually required.

Closes elgentos#59
@peterjaap peterjaap merged commit d9cef02 into elgentos:main Jul 28, 2022
@peterjaap
Copy link
Contributor

Thanks, awesome work!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make tests work on current (1.1.16) Hyvä theme out of the box
2 participants