Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Expand default pattern to also match specs in modules #78

Merged
merged 2 commits into from
Sep 13, 2022
Merged

feat: Expand default pattern to also match specs in modules #78

merged 2 commits into from
Sep 13, 2022

Conversation

Vinai
Copy link
Collaborator

@Vinai Vinai commented Sep 9, 2022

No description provided.

@Vinai
Copy link
Collaborator Author

Vinai commented Sep 12, 2022 •
edited
Loading

I'm not sure that $SPEC_SUITE is the best possible placeholder.
Maybe $FRONTEND or $THEME would be better?

@peterjaap
Copy link
Contributor

Nice! I like it. And I think SPEC_SUITE covers it better when just looking at the var name. THEME or FRONTEND does not signal what is being done with the variable - could be anything.

@peterjaap peterjaap merged commit ba7a744 into elgentos:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vinai @peterjaap