Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fixture property names that caused the account tests to fail #79

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

Vinai
Copy link
Collaborator

@Vinai Vinai commented Sep 12, 2022

I'm not sure how this happened, my guess is that at one point the data in cypress/fixtures/account.json was changed, but the references to the street and the house number in cypress/page-objects/hyva/account.js where not updated.

The old property names are used nowhere else within the repo, so I think it's safe to assume the luma tests where refactored, too, if they used them.

I'm too lazy to git-blame to try and figure out when that happened :)

@peterjaap
Copy link
Contributor

Sorry my bad! I had to split the address up in street + housenumber for a specific project. Then I made another update to the fixture file, and made a PR here but copied this along. Thanks for flagging & fixing.

@peterjaap peterjaap merged commit a844769 into elgentos:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants