Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rest api methods available as cy commands #97

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

Vinai
Copy link
Collaborator

@Vinai Vinai commented Oct 11, 2022

This helps avoid having to specify relative import paths from tests in modules.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This helps avoid having to specify relative import paths from tests in modules.
@Vinai Vinai temporarily deployed to ci October 11, 2022 07:49 Inactive
@Vinai Vinai temporarily deployed to ci October 11, 2022 07:49 Inactive
@peterjaap
Copy link
Contributor

Smart one, I actually put this into the Contributing part in the readme;

Avoid creating global cy functions (Custom Commands), instead put functions in utils/helpers and import them

But the way you do it here is that you get best of both worlds.

@peterjaap peterjaap merged commit 3d2a3bf into elgentos:main Oct 11, 2022
@Vinai
Copy link
Collaborator Author

Vinai commented Oct 12, 2022

Thanks for the merge, I didn't really expect you would like it :D
I think it really is probably the best way to make code from this repo available to tests in a module (that is, in a different folder hierarchy).

@Vinai Vinai deleted the patch-1 branch September 5, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants