add array key to prismic block #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WouterSteen
requested changes
Nov 10, 2023
JeroenBoersma
approved these changes
Nov 10, 2023
Block/Slices.php
Outdated
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| class Slices extends Group | |||
| { | |||
| public function fetchItem(\stdClass $slice): string | |||
| public function fetchItem(\stdClass $slice, $key): string | |||
There was a problem hiding this comment.
:suggestion (non-blocking): you could add the setIterator($key) here too on the block after setDocument
yes, thought I could imagine that need to set a default for the field for backwards compatibility.
effective function fetchItem(..., $key = null)
//...
null !== $key && $block->setIterator($key) |
Yes because it overwrites the Grouped and those need to be compatible... Can you review Wouter? Than we can merge this and tag it as a minor update 🍻 |
WouterSteen
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.