Merge pull request #91 from tuyennn/feature/verbose-mode-handling-dup…

…licate-urls [feat] Move logging detect Duplicated url on current product to verbo…
elgentos · Aug 8, 2024 · a3dd257 · a3dd257
2 parents ced866b + 3e47025
commit a3dd257
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -33,6 +33,7 @@ Arguments:
 Options:
  --store (-s)          Use a specific store (store Id, store code or 'all')
  --root (-r)           Regenerate for root category and its children, ignoring cids. 
+ --verbose (-v)        Verbose mode to display the errors. Eg: duplicated product urls
  --help (-h)           Display this help message
 ```
 

diff --git a/src/Service/RegenerateProductUrl.php b/src/Service/RegenerateProductUrl.php
@@ -55,6 +55,11 @@ class RegenerateProductUrl
      */
     private int $regeneratedCount = 0;
 
+    /**
+     * @var bool
+     */
+    private bool $isVerboseMode = false;
+
     /**
      * Constructor.
      *
@@ -87,11 +92,12 @@ public function __construct(
      */
     public function execute(?array $productIds = null, ?int $storeId = null, bool $verbose = false): void
     {
+        $this->isVerboseMode = $verbose;
         $this->regeneratedCount = 0;
 
         $stores = null !== $storeId
             ? [$this->storeManager->getStore($storeId)]
-            : $this->storeManager->getStores(false);
+            : $this->storeManager->getStores();
 
         foreach ($stores as $store) {
             $regeneratedForStore = 0;
@@ -132,7 +138,7 @@ public function execute(?array $productIds = null, ?int $storeId = null, bool $v
             $newUrls = [];
             /** @var Product $product */
             foreach ($collection as $product) {
-                if ($verbose) {
+                if ($this->isVerboseMode) {
                     $this->log(
                         sprintf(
                             'Regenerating urls for %s (%s) in store (%s)',
@@ -216,19 +222,27 @@ private function replaceUrls(array &$urls, bool $last = false): int
     {
         $this->log(sprintf('replaceUrls%s batch: %d', $last ? ' last' : '', count($urls)));
 
-        foreach ($urls as $url) {
+        if ($this->isVerboseMode) {
+            foreach ($urls as $url) {
+                try {
+                    $this->urlPersist->replace([$url]);
+                } catch (Exception $e) {
+                    $this->log(
+                        sprintf(
+                            $e->getMessage() . ' Entity id: %d Request path: %s',
+                            $url->getEntityId(),
+                            $url->getRequestPath()
+                        )
+                    );
+                }
+            }
+        } else {
             try {
-                $this->urlPersist->replace([$url]);
-            } catch (Exception $e) {
-                $this->log(
-                    sprintf(
-                        $e->getMessage() . ' Entity id: %d Request path: %s',
-                        $url->getEntityId(),
-                        $url->getRequestPath()
-                    )
-                );
+                $this->urlPersist->replace($urls);
+            } catch (Exception $e) {//phpcs:ignore Magento2.CodeAnalysis.EmptyBlock.DetectedCatch
             }
         }
+
         $count = count($urls);
         $urls = [];