Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add coding standard for current version #90

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

tuyennn
Copy link
Contributor

@tuyennn tuyennn commented Jul 31, 2024

Adding current Magento 2 Coding Standard for current base.

Feel free to correct any problem with my changes

Copy link

what-the-diff bot commented Jul 31, 2024

PR Summary

  • Update and addition in various Command-related repositories
    Several properties and constructor arguments have been augmented in files like AbstractRegenerateCommand.php, RegenerateCategoryPathCommand.php, RegenerateCategoryUrlCommand.php, RegenerateCmsPageUrlCommand.php and RegenerateProductUrlCommand.php. These changes include elements such as nullable property introduction and method addition, facilitating improved operations and providing more versatility in command execution.

  • Adjustments to Product Repository
    Product.php has seen an update in its construct method. This can be beneficial as it can allow more secured and flexible initialization of product components.

  • Extension of CategoryUrlPathGenerator class
    In CategoryUrlPathGenerator.php, the class has been amplified for better URL path generation for categories.

  • Development on RegenerateProductUrl
    In RegenerateProductUrl.php, several properties have been modified, alongside the addition of the 'execute' method. Such modifications can offer enhanced efficiency and practicality for URL regeneration tasks.

  • New Classes and Preferences
    New classes and preferences have been introduced within the Elgentos\RegenerateCatalogUrls and Magento\CatalogUrlRewrite\Model\CategoryUrlPathGenerator respectively. These enhancements provide better structured and easier to manage URL regeneration processes for catalogues.

@peterjaap peterjaap merged commit ced866b into elgentos:master Aug 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants