CIEv4 and FDE ahead of its CIE #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses both issues in #562. As always, uncovered some unrelated stuff once the binary hit the test corpus.
The FDE ahead of CIE issue is not handled correctly neither by GNU readelf nor by llvm-dwarfdump nor by eu-readelf.
Along the way, I had to file two bugs against GNU readelf:
Also, the aranges section in the binary looks straight up malformed - there is no entry tuple alignment to the tuple size, as demanded by the standard. Readelf produces nonsensical output on that section, pyelftools conks out. Smells like a bug in IAR.
Over those issues, I had to exclude the new binary from some of the readelf tests. I'll try to patch readelf in the meantime.