[RISCV] add test for GNU note property and CFI support #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerry Zhang Jian <jerry.zhangjian@sifive.com>
Signed-off-by: Jerry Zhang Jian <jerry.zhangjian@sifive.com>
Signed-off-by: Jerry Zhang Jian <jerry.zhangjian@sifive.com>
Signed-off-by: Jerry Zhang Jian <jerry.zhangjian@sifive.com>
|
My only concern is the test strategy. A test against a hand constructed notes section is not indicative of what the binaries in the wild, where the notes section was built by a compiler, would look like. |
|
Well... I am following the implementation in https://github.com/eliben/pyelftools/blob/main/test/testfiles_for_readelf/note_gnu_property.S Maybe we can have a C code test case after the entire CFI support being implemented on the toolchain side. |
|
That was before my time :) Anyway, if you can get a C[++] compiler to emit the right notes section, I think that'd be better. This PR will be sitting for a while anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jerry Zhang Jian jerry.zhangjian@sifive.com