Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Initial working pipeline with minimum tests #1

Merged
merged 11 commits into from
May 1, 2020
Merged

feat: Initial working pipeline with minimum tests #1

merged 11 commits into from
May 1, 2020

Conversation

tayowonibi
Copy link
Contributor

@tayowonibi tayowonibi changed the title feat: Initial Unstested Working Pipeline feat: Initial Untested Working Pipeline Apr 28, 2020
@tayowonibi tayowonibi requested a review from de-code April 29, 2020 00:02
@tayowonibi tayowonibi changed the title feat: Initial Untested Working Pipeline feat: Initial Working Pipeline With Minimum Test Apr 29, 2020
@tayowonibi tayowonibi changed the title feat: Initial Working Pipeline With Minimum Test feat: Initial working pipeline with minimum tests Apr 29, 2020
@tayowonibi
Copy link
Contributor Author

code from the converter are in the data_pipeline.model, data_pipeline.transform_zip_xml, and data_pipeline.utils.xml_transform_util

de-code
de-code reviewed Apr 29, 2020
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
de-code
de-code reviewed Apr 29, 2020
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
de-code
de-code reviewed Apr 29, 2020
View reviewed changes
install.sh Outdated Show resolved Hide resolved
@de-code
Copy link
Collaborator

de-code commented Apr 29, 2020

Is amanuscript_version_table_test in me_dev and example of the output?
You mentioned in the meeting that there will be a need to map fields due to the new version being incompatible? What has changed?
Wouldn't we just need to select the last version for each entity to produce the same tables as before?

I think we probably are meeting the magically rule of three criteria. And it might be good to refactor some of the duplication across the multiple dags repos.

@tayowonibi
Copy link
Contributor Author

Is amanuscript_version_table_test in me_dev and example of the output?
You mentioned in the meeting that there will be a need to map fields due to the new version being incompatible? What has changed?
Wouldn't we just need to select the last version for each entity to produce the same tables as before?

yes you are right, there are no changes in the structure. just some question here about the selection of the latest version in postgresql which i will be asking here later

@tayowonibi
Copy link
Contributor Author

@de-code - i've responded to all the pr's so far. do you have, are there other things you feels need to be done here?

@tayowonibi tayowonibi merged commit 25d92a4 into develop May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@de-code de-code de-code approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tayowonibi @de-code