Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setuptools from install_requires #8

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Remove setuptools from install_requires #8

merged 1 commit into from
Mar 18, 2022

Conversation

remcohaszing
Copy link
Contributor

This package simply doesn't require setuptools for installation.

  • When installing from a wheel, setuptools isn't needed.
  • When installing from an sdist and setuptools isn't installed, setup.py will fail to import setuptools on line 1.

This package simply doesn't require setuptools for installation.

- When installing from a wheel, setuptools isn't needed.
- When installing from an sdist and setuptools isn't installed, setup.py will fail to import setuptools on line 1.
@huxuan
Copy link

huxuan commented Mar 18, 2022

Hi @elijahandrews, would you consider this pull request or similar refinement?

I encountered a related issue when have setuptools in constraint file, new version of pip will complain the following error. Remove it or adding a loose constraint, e.g., setuptools>=50.0.0 should fix the issue.

ERROR: Cannot install flake8-blind-except==0.2.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    flake8-blind-except 0.2.0 depends on setuptools
    The user requested (constraint) setuptools==50.3.1

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

@elijahandrews
Copy link
Owner

Thanks! Sorry I let this sit for a while, merging now.

1 similar comment
@elijahandrews
Copy link
Owner

Thanks! Sorry I let this sit for a while, merging now.

@elijahandrews elijahandrews merged commit 8d1f469 into elijahandrews:master Mar 18, 2022
@elijahandrews
Copy link
Owner

This has been released in version 0.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants