Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom fonts for non-English Bibles #187

Closed
otseng opened this issue Feb 24, 2021 · 16 comments · Fixed by #209
Closed

Support custom fonts for non-English Bibles #187

otseng opened this issue Feb 24, 2021 · 16 comments · Fixed by #209
Assignees
Labels
enhancement New feature or request

Comments

@otseng
Copy link
Collaborator

otseng commented Feb 24, 2021

Would like to see my non-English Bibles in a native language font.

@otseng otseng self-assigned this Feb 24, 2021
@eliranwong eliranwong added the enhancement New feature or request label Feb 24, 2021
@otseng
Copy link
Collaborator Author

otseng commented Feb 26, 2021

@onegladiator4u
What non-English bible are you using?
Where can I get it?
What is the name of the font you want to use?

@onegladiator4u
Copy link

I just uploaded to drive. the language is Malayalam. It's an Indian language.
https://drive.google.com/file/d/1Jl0S0RFObb1w-e-6qjVmuSrB-C4nL4fq/view?usp=sharing
May I know why you need this? I thought this will work for all non English language.

@otseng
Copy link
Collaborator Author

otseng commented Feb 26, 2021

Thanks. I want to make it so when you select this Bible, it will automatically select your language font.

@onegladiator4u
Copy link

Oh ok. Will that happen to all non English Bible too? This will be difficult right ? Since people prefer different font in their own native language.

@eliranwong
Copy link
Owner

eliranwong commented Feb 26, 2021

@otseng I prefere not to use a single font for all bibles of a single language if possible. Because even bible modules have the same languages, they can require different font files.

a read example is that, SBLGNT greek bible requires a specific font in some other softwares. So, SBLGNT uses a specific font, some other Greek bibles use other fonts. It won't work if you assign a single font to all bibles of a single language. SBLGNT is only one of the examples, there are many different other examples.

It would be more flexible if bible module details table can specify a font the module creator would like to display it.

@otseng
Copy link
Collaborator Author

otseng commented Feb 26, 2021

Yes, I'll do that instead to make it most flexible. I'll have a specific font(s) tied to a specific Bible.

@eliranwong
Copy link
Owner

@otseng I think it would be nice if user can specify font for a bible by using the font dialog window, like the one we use to select default font in general, so that users can change font for a bible even they have no knowledge about sqlite file.

my brief idea is described below

  • in each bible file, we may consider add an entry "font" in "Details" table
  • the font entry is empty by default
  • if user doesn't specify a font for the opened bible, general default font will be used for displaying its bible text
  • if a user want to specify a font for a bible, they can first open a bible on main window
  • then open font dialog to specify a font for the opened bible.
  • when they click "ok" button on font dialog box, the app insert the font entry in Details table for users, so they don't need to manually handle the sqlite file.

just a suggestion, what do you think?

@onegladiator4u
Copy link

Do you guys think 'details' table need only one entry? I thought it'll be needing font size too.
I want to suggest one more thing that after introducing this feature when Opening a bible version or moving to a different tab the font display portion also gets updated in case you missed.
image
For example if we opened two Bible versions in tabs
image
If that font display portion don't get updated when switching tabs if we increase or decrease font size using buttons the font might charge.
Just a suggestion.

@eliranwong
Copy link
Owner

Do you guys think 'details' table need only one entry? I thought it'll be needing font size too.
I want to suggest one more thing that after introducing this feature when Opening a bible version or moving to a different tab the font display portion also gets updated in case you missed.
image
For example if we opened two Bible versions in tabs
image
If that font display portion don't get updated when switching tabs if we increase or decrease font size using buttons the font might charge.
Just a suggestion.

I think it would be nice to also have font size entry for each bible.

but regarding the button, I suggest not to change the button display, as many tabs could be opened on many different kinds of resources or features (on a tab show compare or parallel versions, different fonts could be used on the same tab if different versions are compared). changing display of this button can cause confusion. I would like to have this button dedicated to the default font and size.

@onegladiator4u
Copy link

Oh ok. Understood the problem.

@eliranwong
Copy link
Owner

I think custom font would be a very useful feature. Long time ago, a Russian brother already asked me for custom font on individual commentaries. Thanks for bringing up this issue.

@otseng
Copy link
Collaborator Author

otseng commented Feb 26, 2021

Ok, so the details table in the bible file would contain the font name and font size.

I'll create a way to configure this for an individual bible. Then use this info during the display of the bible.

@otseng otseng linked a pull request Feb 27, 2021 that will close this issue
@otseng
Copy link
Collaborator Author

otseng commented Feb 27, 2021

Significant changes with this one, so there could be issues. Please create a new issue to report it.

To use, select "Modify Database" in menu. This has been added to all menus.

Select the Bible database file, enter font size and select font name. Try "x-small" or "x-large" for font size.

Now, when reading a Bible, it will apply that style only to that Bible.

This only works when reading a single Bible. It does not work when comparing verses with different Bibles.

@onegladiator4u
Copy link

@otseng Can we expect a future update where it works on comparing verses with different Bible's too?

@otseng
Copy link
Collaborator Author

otseng commented Feb 27, 2021

@otseng Can we expect a future update where it works on comparing verses with different Bible's too?

Yes, that can be added at a later date.

@onegladiator4u
Copy link

@otseng thanks for the update.

otseng added a commit that referenced this issue Jan 14, 2022
Ver 26.43; Add create lexicon from notes (#187)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants