Relax myxql dependency #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 💙 💜 💛 ❤️ |
|
Will this be released in an updated version soon? I'm just starting a project to upgrade to Elixir 1.16 (or maybe 17) and doing the usual full set of upgrades, but myxql 0.7.0 is being blocked. Thanks. |
josevalim
pushed a commit
that referenced
this pull request
Jun 13, 2024
|
v3.11.3 is out. |
|
That's what I call turnaround. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relaxes the MyXQL dependency from
~> 0.6.0to~> 0.6so version0.7.0is allowed. I don't think0.7.0contains any changes that would cause it not to work with the current version ofecto_sql.I'm not sure if it's intentionally pinnend to
0.6.0, if so it's probably better to use"~> 0.6.0 or ~> 0.7.0".