Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Ecto.Adapters.SQL.with_log/3 public #615

Closed
wants to merge 1 commit into from
Closed

make Ecto.Adapters.SQL.with_log/3 public #615

wants to merge 1 commit into from

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Jun 13, 2024 •
edited
Loading

In place of #614

This PR makes it easier to implement custom functions in adapters by making Ecto.Adapters.SQL.with_log/3 public.

@ruslandoga ruslandoga mentioned this pull request Jun 13, 2024
Closed
@josevalim
Copy link
Member

Between the two changes, I would prefer to make query accept a map. :) with_log is really internal and depends on internal fields like telemetry, that I don't feel very comfortable in exposing. Sorry :)

@ruslandoga ruslandoga closed this Jun 13, 2024
@ruslandoga ruslandoga deleted the make-with_log-public branch June 15, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruslandoga @josevalim