Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous PR we hardcoded the precision to 6 because we didn't know how to deal with the type modifier.
I got pointed in the right direction by the nice people at Postgres. The type modifier for intervals takes into account two different things:
days
,years
,days to years
and stuff like that), represented as a 16-bit bit fieldThe right most 16 bits in the type modifier are the precision. I was pointed to the right places in their code here and here
We could probably do something about the fields modifier as well but that is a lot more complex. And we ignore it already today. So going to think on it a bit and save it for later.