Raise a nice error message of params is not a list #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WDYT about adding is_list(params) to Postgrex.query, execute, and similar functions? We’d still get no function clause error but I believe it would be a more relevant error message. But ArgumentError is fine too though I’d consider raising it from that query and friends, I think shorter stacktrace is preferred. |
|
Good point! Changed. |
|
merge conflicts =/ will fix |
greg-rychlewski
force-pushed
the
params_error_msg
branch
from
cd57415 to
69cf80c
Compare
|
ok all better now |
josevalim
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can help if the user is passing a single value as a parameter or something like that. Otherwise the function clause error can be a bit cryptic.