Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to exif data decoding #169

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

hansihe
Copy link
Contributor

@hansihe hansihe commented Oct 2, 2024

Two small tweaks to support images I have encountered from smartphones

  • datetime_original_offset and datetime_digitized_offset which is the offsets for datetime_original and datetime_digitized
  • Alternate encoding of tags which return version. This crashed before this change.

* `datetime_original_offset` and `datetime_digitized_offset` which is
  the offsets for `datetime_original` and `datetime_digitized`
* Alternate encoding of tags which return `version`. This crashed before
  this change.
@kipcole9 kipcole9 merged commit 8106712 into elixir-image:main Oct 2, 2024
@kipcole9
Copy link
Collaborator

kipcole9 commented Oct 2, 2024

Fantastic, thanks very much @hansihe. EXIF has got to be one of the least standard standards even! I'll push an new release in about an hour.

@kipcole9
Copy link
Collaborator

kipcole9 commented Oct 2, 2024

I've published image version 0.54.4 with the following changelog entry:

Bug Fixes

Thanks again for the PR!

@hansihe hansihe deleted the exif-decode-improvements branch October 3, 2024 08:19
@hansihe
Copy link
Contributor Author

hansihe commented Oct 3, 2024

Thanks a ton for merging and publishing this so quickly!

Will be sure to contribute if I find any more edge-cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants