Support other unique constraint error format #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unique constraints sometimes fail with the following error format:
UNIQUE constraint failed: index '<index_name>'
I believe this happens when the index name doesn't match
the names of the columns involved.
Example of an index for which this happens:
CREATE UNIQUE INDEX test_user_id_number_year_index
ON invoices (user_id, number, strftime('%Y', created_at));
warmwaffles
reviewed
May 15, 2023
|
|
||
| test "simple unique index" do | ||
| error = %Exqlite.Error{message: "UNIQUE constraint failed: one.two.three"} | ||
| assert Connection.to_constraints(error, []) == [unique: "one_two_three_index"] |
There was a problem hiding this comment.
Shouldn't this be unique: "one.two.three"?
There was a problem hiding this comment.
No, not in my testing.
I've done some more testing and added specific index examples I've used so it can be reproduced / tested against future SQLite versions.
Does it make more sense now?
Thanks for looking at this.
There was a problem hiding this comment.
OH, I was looking at this as trying to extract the one.two.three portion out of the string, but completely missed that this is missing the index part of the string.
warmwaffles
approved these changes
May 16, 2023
|
Released under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unique constraints sometimes fail with the following error format:
UNIQUE constraint failed: index '<index_name>'I believe this happens when the index name doesn't match the names of the columns involved.
Example of an index for which this happens:
Resolves #89