Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary uuid casting #121

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

greg-rychlewski
Copy link
Contributor

I think this solves your issue here: #119

I'm not too familiar with SQLite but from what I can tell from the tests it doesn't like it when cast(_ as blob) is used. It seems to work when the casting is removed.

Copy link
Member

@warmwaffles warmwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. I'll need to chuck a test or two into the ecto/adapters/sqlite3/connection directory that check the select statements but this solves the immediate problem.

@warmwaffles warmwaffles merged commit 5ddb7a5 into elixir-sqlite:main Aug 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants