improvement: support {:unsafe_fragment, ".."} as a conflict target
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachdaniel
commented
Oct 10, 2023
zachdaniel
force-pushed
the
unsafe-fragment-conflict-target
branch
from
7b97dce
to
d03824e
Compare
warmwaffles
approved these changes
Oct 10, 2023
|
This looks good. I'll merge it once CI passes. It would be nice to have a test added for this. I don't know if there are unsafe fragment tests in the integration suite provided by |
|
👍 will add one |
zachdaniel
force-pushed
the
unsafe-fragment-conflict-target
branch
from
d03824e
to
fe54500
Compare
this is supported by other sql data layers, for example. This is necessary for AshSqlite3's upsert behavior. Postgres adapter implementation: https://github.com/elixir-ecto/ecto_sql/blob/v3.10.2/lib/ecto/adapters/postgres/connection.ex#L212C4-L213C26
zachdaniel
force-pushed
the
unsafe-fragment-conflict-target
branch
from
fe54500
to
d6d5f11
Compare
|
Alright, added a test :) |
|
Perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is supported by other sql data layers, for example. This is necessary for AshSqlite3's upsert behavior. Postgres adapter implementation: https://github.com/elixir-ecto/ecto_sql/blob/v3.10.2/lib/ecto/adapters/postgres/connection.ex#L212C4-L213C26