Make uuid encoding configurable and consistent #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinlang
suggested changes
Aug 27, 2021
|
LGTM |
kevinlang
approved these changes
Aug 27, 2021
|
I'll merge this and issue a new release later today |
|
One slight change, can you add a line to the CHANGELOG? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the UUID handling configurable and also consistent.
It seems by now
:binary_idfields were not encoded (string uuid stored), whileEcto.UUIDfields were actually stored encoded to the binary form.I've opted to leave the
:stringform the default, though it's still a breaking change given the two types were not consistent before.Closes #51