Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Generate binary_id values according to the binary_id_type config #72

Merged
merged 2 commits into from
May 22, 2022
Merged

fix: Generate binary_id values according to the binary_id_type config #72

merged 2 commits into from
May 22, 2022

Conversation

Blond11516
Copy link
Contributor

Adds support for auto-generating binary_id values in either string or binary format according to the :binary_id_type config.

@Blond11516 Blond11516 mentioned this pull request May 19, 2022
Closed
warmwaffles
warmwaffles approved these changes May 19, 2022
View reviewed changes
test/ecto/adapters/sqlite3_test.exs Outdated Show resolved Hide resolved
test/ecto/adapters/sqlite3_test.exs Show resolved Hide resolved
@warmwaffles warmwaffles added the enhancement New feature or request label May 19, 2022
@warmwaffles
Preserve binary_id_type config value in-between tests
96d0f0d 
Co-authored-by: Matthew Johnston <warmwaffles@gmail.com>
@warmwaffles warmwaffles merged commit ee43b00 into elixir-sqlite:main May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warmwaffles warmwaffles warmwaffles approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Blond11516 @warmwaffles