Change Wallaby.Browser.sync_result from opaque to type

[TheFirstAvenger]

Fixes #539.

Changes Wallaby.Browser.sync_result from @opaque to @type.

[codecov-commenter]

Codecov Report

Merging #540 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #540   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files          26       26           
  Lines         853      853           
=======================================
  Hits          791      791           
  Misses         62       62           

Flag	Coverage Δ
#IntegrationTest	87.69% <ø> (-0.12%)	⬇️
#UnitTest	39.39% <ø> (ø)

Impacted Files	Coverage Δ
lib/wallaby/browser.ex	93.54% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f615b7d...ed9c096. Read the comment docs.

[mhanberg]

Thanks for the PR!

I am curious as to why dialyzer doesn't complain about this in the Wallaby codebase 🤔.

[TheFirstAvenger]

I am curious as to why dialyzer doesn't complain about this in the Wallaby codebase 🤔.

From what I can see, assert_has is never called in compiled code in the Wallaby codebase, only in tests.

[mhanberg]

Ohh, that makes sense!

[mhanberg]

Do you mind also adding this change to the changelog?

[TheFirstAvenger]

Do you mind also adding this change to the changelog?

Done

[mhanberg]

v0.26.1 has been released with this change.

Thanks for the contribution!