fix(i18n): Update nl-NL.json #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refinements
|
|
✅ Deploy Preview for elk-docs canceled.
|
|
This one looks like it's based on an older version of the file: #1214 (but are also good improvements). |
haayman
reviewed
Jan 16, 2023
locales/nl-NL.json
Outdated
| "request_error": "Er is een error tijdens het ophalen van de subscriptie, probeer opnieuw en als de error blijft, raporteer het probleem naar de Elk repository.", | ||
| "title": "Kon niet subscriben aan push notificaties" | ||
| "request_error": "Er is een error tijdens het ophalen van het lidmaatschap, probeer opnieuw en als de error blijft, raporteer het probleem naar de Elk repository.", | ||
| "title": "Kon niet lid worden van de pushnotificaties" |
There was a problem hiding this comment.
isn't 'abonnement' or 'abonneren' better?
There was a problem hiding this comment.
Agree. Abonnement for 'subscriptie' and 'abonneren' for 'lid worden'
|
Can we combine the two into one perhaps? |
|
@jan-vandenberg merged #1214 so it is easier to merge it into this one. Please merge main to the PR and resolve the conflicts and we can then merge this PR too. |
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Co-authored-by: Joran Quinten <joran@joranquinten.nl>
patak-dev
approved these changes
Feb 25, 2023
DataDrivenMD
pushed a commit
to Distal-Labs/elk
that referenced
this pull request
Mar 11, 2023
Co-authored-by: Joran Quinten <joran@joranquinten.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refinements
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).