docs: add cloudflare pages deployment guide #1494
Conversation
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
danielroe
changed the title
There was a problem hiding this comment.
Before merging this:
- I've left a couple of minor comments
- we also should add a note that Cloudflare Pages deployment is not yet fully supported (as you can't yet log in), and maybe link to the relevant issue: Cloudflare page will always get 405 error for non-GET method nitrojs/nitro#787
|
Just dropping a quick note that I haven't forgotten about this PR-- I'm waiting until we sort out the HTTP 405s that prevent users from logging into the app when it is deployed to Cloudflare Pages (and CF Workers Sites). Once we get that squared away, I plan to circle back to make the requested changes to this PR along with any additional steps that may be necessary to a deploy a fully-functioning Elk instance on CF Pages |
|
Just submitted PR #1798 which unblocks work on this PR (#1494). I'll circle back sometime over the weekend to make the changes requested by @danielroe + to expand on the instructions to incorporate additional details necessary to deploy to CF Pages with CI |
Added links to three issues that report the same bug in Nitro: Also, I submitted a PR (#1798 #1798) that resolves the issue for the Elk project. The rationale for an Elk-specific workaround as implemented in PR 1798 (regardless of how/when/if the Nitro bug is fixed) is presented here |
Socket Security Pull Request Report👍 No dependency changes detected in pull request Pull request report summary
Powered by socket.dev |
|
Hey @danielroe this PR should be ready for re-review at your convenience. It incorporates the changes you requested during the original PR review plus updates the Cloudflare Pages deployment guide to account for nitrojs/nitro#965 |
|
o no - don't close it! |
|
@danielroe Crap. I synchronized with upstream without realizing that I created this PR directly from main. Sorry about that. Will revert. |
|
@danielroe Double crap. I can't revert because the command was a force-push to my That was a rookie move on my part. Sorry about that. |
|
no problem at all - sorry it has taken me so long to review! |
|
No worries. I've been away from this project for a couple of weeks, which is why I mindlessly performed a hard sync with the upstream repo-- thinking that I probably missed so much that it would be more efficient to clear the table and start from scratch 🤦🏻♂️ |
**NOTE** This is a resubmission of [PR elk-zone#1494](elk-zone#1494), which was inadvertently closed by a force-push - [X] Add Cloudflare Pages to deployment guide - [X] Refactor Netlify deployment guide - [X] Add Getting Started page to the deployment guide that covers topics that are common/shared by multiple deployment types - [X] Add cloudflare_pages.yml workflow file (set to workspace/manual trigger)
**NOTE** This is a resubmission of [PR elk-zone#1494](elk-zone#1494), which was inadvertently closed by a force-push - [X] Add Cloudflare Pages to deployment guide - [X] Refactor Netlify deployment guide - [X] Add Getting Started page to the deployment guide that covers topics that are common/shared by multiple deployment types - [X] Add cloudflare_pages.yml workflow file (set to workspace/manual trigger)
This PR includes a step-by-step deployment guide for use on Cloudflare Pages as well as a GitHub Actions
.ymlfile that can be used as part of a CD/CI workflow.