Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update nuxt to v3.8.2 #2490

Merged
merged 1 commit into from
Nov 29, 2023
Merged

chore: update nuxt to v3.8.2 #2490

merged 1 commit into from
Nov 29, 2023

Conversation

danielroe
Copy link
Member

No description provided.

@danielroe danielroe self-assigned this Nov 29, 2023
Copy link

stackblitz bot commented Nov 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 89f7255
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/65677c9e473d6c000847c066
😎 Deploy Preview https://deploy-preview-2490--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 89f7255
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/65677c9e4cad030008c9823d

Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@nuxt/devtools 1.0.0-beta.1...1.0.4 None +9/-8 19.1 MB antfu
nuxt 3.7.4...3.8.2 None +18/-12 37.8 MB danielroe

@danielroe danielroe marked this pull request as ready for review November 29, 2023 18:38
@patak-dev patak-dev added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit 17f6d93 Nov 29, 2023
15 checks passed
@patak-dev patak-dev deleted the chore/nuxt-3.8.2 branch November 29, 2023 22:28
@userquin
Copy link
Member

userquin commented Dec 1, 2023

uhmm, we should change nuxt hook for sw generation, these lines https://github.com/elk-zone/elk/blob/main/modules/pwa/index.ts#L220-L224 should be replaced with:

        nuxt.hook('nitro:build:public-assets', async () => {
          await resolveVitePluginPWAAPI()?.generateSW()
        })

@patak-dev
Copy link
Member

Would you send that PR @userquin once you have some time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants