[pull] master from ipfs:master #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Renamed UpgradeableDirectory to DynamicDirectory to indicate that we can switch between Basic and HAMT Directories * Transition between HAMT directory and Basic Directory based on the global sharding threshold * Unexported BasicDirectory.SwitchToSharding as an unnecessary exposure point until requested * NewDirectoryFromNode always returns a DynamicDirectory instead of an UpgradeableDirectory or HAMTDirectory * Added Swap and Take functions to HAMT Shards * Fix for the size estimation logic where we were not tracking that replacing an entry with a differently sized CID could trigger switching between being a Basic or HAMT directory * Use custom parallel DAG traversal to the EnumLinksAsync for HAMTs that is closer to DFS than BFS * Added lots of comments to the HAMT code * Exported LogTwo function to make it more accessible within the package Co-authored-by: Lucas Molas <schomatis@gmail.com> Co-authored-by: Adin Schmahmann <adin.schmahmann@gmail.com>
- go-blockservice - go-ipfs-blockstore - go-ipfs-exchange-offline - go-merkledag
When automatically switching a BasicDirectory to a HAMTDirectory because it grew too big, the current code: * loops every link in the BasicDirectory * reads each node referenced by those links * adds the nodes to a new HAMTDirectory shard, which in turn: * writes the nodes to the DAG service (they were just read from there!) * makes a link out of them (identical to the link in the BasicDirectory!) This would happen to about (~4000 nodes), which are fully read and written for nothing. This PR adds a new SetLink method to the HAMT Shard which, instead of taking an ipld.Node like Set(), takes directly an ipld.Link. Then it updates switchToSharding() to pass the links in the BasicDirectory directy, rather than reading all the nodes. Note that switchToBasic() works like this already, only using the links in the HAMT directory.
Set version to v0.3.2
* Fix panic when childer is nil Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com> * Apply suggestions from code review Co-authored-by: Gus Eggert <gus@gus.dev> Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com> Co-authored-by: Gus Eggert <gus@gus.dev>
fix: correctly handle degenerate hamts while reading data
this will lose block when newRoot.AddChild returns err. in ipfs-cluster single dag service add(context.TODO(), node) maybe failed when not enough peers to allocate for this block node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )