Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend testing (using mock capture sources) #88

Closed
3 tasks done
fako1024 opened this issue Mar 22, 2023 · 2 comments · Fixed by #118
Closed
3 tasks done

Extend testing (using mock capture sources) #88

fako1024 opened this issue Mar 22, 2023 · 2 comments · Fixed by #118
Assignees
Labels
feature New feature or request
Milestone

Comments

@fako1024
Copy link
Collaborator

fako1024 commented Mar 22, 2023

Depends on fako1024/slimcap#7 , in which a way of mocking a fully functional capture source is provided.

DoD

@fako1024
Copy link
Collaborator Author

The good news is that I got a full-blown E2E test to work, including goProbe / goQuery round-trip. The bad news is that the tests did reveal a race condition in the ring buffer mock source which will require some fixing. Since I'll be afk next week I'll probably have to continue after that. @els0r FYI.

@els0r
Copy link
Owner

els0r commented Apr 22, 2023

The good news is that I got a full-blown E2E test to work, including goProbe / goQuery round-trip. The bad news is that the tests did reveal a race condition in the ring buffer mock source which will require some fixing. Since I'll be afk next week I'll probably have to continue after that. @els0r FYI.

I would call that double good news if more rigorous testing reveals previously unknown flaws.

Thanks for letting me know. I'll chip away at #43 in the meantime.

Cheers from Portland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants