-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Implementation of several micro-optimizations #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fako1024
added
feature
New feature or request
performance
Performance / optimization related topics
labels
May 24, 2023
6 tasks
fako1024
commented
May 24, 2023
els0r
approved these changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me gusta.
Would be great if you can do the rename of GPFlow
to Flow
All done, thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following high-level changes are incorporated in this PR (see also the issue #83 for details / numbers):
GPPacket
layer (instead direct interaction with the flow map, saves overhead and simplifies code)select {}
statement in core processing routine (this has been bothering me from the beginning - with the new two-way lock concept it's simply not necessary anymore)@els0r I'll add a few comments in the code as usual for brevity, feel free to ping me if any further questions arise.
Final sidenote: I even tried to replace the whole
map[string]*GPFlow
logic with the new hashmap - it looked promising at first, but it turns out that using*GPFlow
pointers as map values (and then changing counters on the pointers directly) significantly outweighs the improvements that come from thehashmap
. As soon as there are more than a few items in the map the additional lookups required to change the values (even in place) bring me on par with the current implementation at best (while being less readable), so I decided to skip that.