[bugfix] Remove cyclic calls for Prettier / Pretty() interface & implementation #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fako1024
changed the title
els0r
approved these changes
Mar 8, 2024
| @@ -276,11 +276,6 @@ func (err *ArgsError) Pretty() string { | |||
| ` | |||
| errStr := err.err.Error() | |||
|
|
|||
| var prettyErr types.Prettier | |||
| if errors.As(err, &prettyErr) { | |||
| errStr = "\n" + types.PrettyIndent(prettyErr, 4) | |||
There was a problem hiding this comment.
Unfortunately, I didn't comment this. Are you sure there wasn't a reason for it? As in: did you provoke the error and check if printing behavior is the same?
Update: never mind. Just read the issue. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of the crashes. However TBH I'm not supa happy with the current setup, mostly because it's inconsistent. There are places where it's asserted if an error is a
Prettier, then a few lines later an error is generated that just assumes to be. We should revisit the whole console output / pretty / non-pretty concept IMHO at some point (and be as generic as possible, adding a few helper functions maybe to make our lives easier).