Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Improve handling of context cancel in DBWorkManager to be more responsive #276

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

fako1024
Copy link
Collaborator

@fako1024 fako1024 commented Mar 7, 2024

Moves handling of context termination down one layer into the processing loop to be able to cancel more quickly.

Closes #273

@fako1024 fako1024 added the bug Something isn't working label Mar 7, 2024
@fako1024 fako1024 requested a review from els0r March 7, 2024 10:48
@fako1024 fako1024 self-assigned this Mar 7, 2024
@fako1024 fako1024 linked an issue Mar 7, 2024 that may be closed by this pull request
@fako1024 fako1024 changed the title [bugifx] Improve handling of context cancel in DBWorkManager to be more responsive [bugfix] Improve handling of context cancel in DBWorkManager to be more responsive Mar 7, 2024
Copy link
Owner

@els0r els0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand now. Makes more sense this way, yes.

pkg/goDB/DBWorkManager.go Outdated Show resolved Hide resolved
Co-authored-by: Lennart Elsen <els0r@users.noreply.github.com>
@fako1024 fako1024 merged commit 6418da3 into main Mar 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goQuery does not (reliably) respond to Ctrl-C
2 participants